Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add footer to all install from binary pages #864

Merged
merged 3 commits into from
Sep 20, 2023
Merged

docs: add footer to all install from binary pages #864

merged 3 commits into from
Sep 20, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Sep 19, 2023 •
edited
Loading

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@braindigitalis braindigitalis self-assigned this Sep 19, 2023
@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6509a2119d357c5bba0da16f
😎 Deploy Preview https://deploy-preview-864--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor

The hyperlink in the footer seems to be broken.
image

@braindigitalis
Copy link
Contributor Author

The hyperlink in the footer seems to be broken. image

it's already fixed, give netlify time to re-run :)

@braindigitalis braindigitalis marked this pull request as ready for review September 19, 2023 13:21
@braindigitalis braindigitalis changed the base branch from dev to master September 19, 2023 13:26
@braindigitalis braindigitalis changed the base branch from master to dev September 19, 2023 13:26
@Jaskowicz1
Copy link
Contributor

Yep, all good now :)

@Jaskowicz1
Copy link
Contributor

Actually, are the end-lines not required? Some of these pages seem to no longer have them now.

@braindigitalis braindigitalis merged commit ee26853 into dev Sep 20, 2023
27 checks passed
@braindigitalis braindigitalis deleted the installation_doc_footer_note branch September 20, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealTimeChris RealTimeChris RealTimeChris approved these changes

Assignees

@braindigitalis braindigitalis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@braindigitalis @Jaskowicz1 @RealTimeChris